From c437b4d5083d11cbac4b2120d67d0e91cb6e8763 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stanislav=20Angelovi=C4=8D?= Date: Mon, 25 Sep 2023 08:53:24 +0200 Subject: [PATCH] fix: honor CMAKE_POSITION_INDEPENDENT_CODE when building (#361) --- CMakeLists.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 7332b239..63a3b83a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -115,7 +115,7 @@ set(CMAKE_CXX_STANDARD 17) set(SDBUSCPP_VERSION_MAJOR "${PROJECT_VERSION_MAJOR}") set(SDBUSCPP_VERSION "${PROJECT_VERSION}") -# We promote BUILD_SHARED_LIBS flags to (global) option only if we are the main project +# We promote the BUILD_SHARED_LIBS flag to a (global) option only if we are the main project if(CMAKE_SOURCE_DIR STREQUAL PROJECT_SOURCE_DIR) option(BUILD_SHARED_LIBS "Build shared libraries (.so) instead of static ones (.a)" ON) endif() @@ -129,8 +129,8 @@ target_compile_definitions(sdbus-c++-objlib PRIVATE SDBUS_HEADER=<${LIBSYSTEMD}/sd-bus.h>) target_include_directories(sdbus-c++-objlib PUBLIC $ $) -if(DEFINED BUILD_SHARED_LIBS) - set_target_properties(sdbus-c++-objlib PROPERTIES POSITION_INDEPENDENT_CODE ${BUILD_SHARED_LIBS}) +if(BUILD_SHARED_LIBS) + set_target_properties(sdbus-c++-objlib PROPERTIES POSITION_INDEPENDENT_CODE ON) endif() if(BUILD_LIBSYSTEMD) add_dependencies(sdbus-c++-objlib LibsystemdBuildProject)