Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a ThisExpression #43

Closed
oxisto opened this issue Jan 23, 2020 · 2 comments
Closed

Create a ThisExpression #43

oxisto opened this issue Jan 23, 2020 · 2 comments
Assignees
@konradweiss
Labels
enhancement New feature or request

Comments

@oxisto
Copy link
Member

oxisto commented Jan 23, 2020

Currently, this is handled as a dummy field of a record declaration. While this works, it is not very clean in my opinion and also leads to funny errors, such as object.this.call() is parsed.

We should replace it with a ThisExpression that refers to the record declaration and can be used as a base for member field access and calls.
@oxisto oxisto mentioned this issue Jan 31, 2020
Closed
@JulianSchuette JulianSchuette added the enhancement New feature or request label Jul 2, 2020
@oxisto oxisto mentioned this issue Mar 9, 2021
Merged
8 tasks
@KuechA
Copy link
Contributor

KuechA commented Aug 17, 2022

@oxisto has this been fixed by #835? Seems to be related

@oxisto
Copy link
Member Author

oxisto commented Aug 17, 2022

@oxisto has this been fixed by #835? Seems to be related

Yes, this can be closed.

@oxisto oxisto closed this as completed Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konradweiss konradweiss

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JulianSchuette @oxisto @konradweiss @KuechA