Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a solution for "problems" in AST, passes and parsing #1679

Open
oxisto opened this issue Sep 6, 2024 · 1 comment
Open

Find a solution for "problems" in AST, passes and parsing #1679

oxisto opened this issue Sep 6, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@oxisto
Copy link
Member

oxisto commented Sep 6, 2024

Following the discussion in #1663 (comment), we want to have a solution for all kind of "problems", either from parsing/translating the AST, as well as executing things in the passes.

These "problems" should have different types and probably be stored in either the translation result or context, so that we can access them after everything runs for debugging. This would also allows us to have some kind of information how "good" the translation / passes were.

@oxisto oxisto added the enhancement New feature or request label Sep 6, 2024
@konradweiss
Copy link
Collaborator

I like the idea of having ProblemNodes in the AST and additional ProblemNodes in the TranslationResult for the more general problems. However, when we have one of these more general problems, do we want it to reference a "location" or another node that is relevant to the problem? For example, a reference that could not be resolved. Or have one general ProblemNode("Reference could not be resolved") with edges to all appearances of that problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants