Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert flux.js to an ES6 module? #12

Open
amellnik opened this issue Mar 24, 2018 · 2 comments
Open

Convert flux.js to an ES6 module? #12

amellnik opened this issue Mar 24, 2018 · 2 comments

Comments

@amellnik
Copy link
Collaborator

Would people be open to splitting the js portion into a new repository, converting it to ES6 and adding it to npm? This would simplify the process of using it with webpack, managing dependencies, etc.

@MikeInnes
Copy link
Member

I'm not against, but while the code is not that stable my thinking was that it might be easier just to inline the fluxjs code wherever it's needed – then you just have something that won't break when an update is released.

Do you have any thoughts on how to keep the Julia and JS sides of the codebase in sync, as they'd presumably have to be in different repos? Again, may just not be an issue if we stabilise a bit.

@amellnik
Copy link
Collaborator Author

I'm not sure of the best way to keep them in sync, but will keep thinking about it. I think you're right that this wouldn't make sense to do before things stabilize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants