[charts/redis-ha] Fix redis-cli --tls argument usage #237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When you run Redis with TLS with
authClients
set to "no", the fix-split-brain sidecar does not talk to Redis or Sentinel over TLS.authClients
only configures whether or not mutual TLS is required therefore moving the--tls --cacert
arguments out of the conditional checkingauthClients
fixes this issue.Also updated the
TLS_CLIENT_OPTION
so that--cert
and--key
are only used if client authentication is required.Example Helm values snippet
Which issue this PR fixes
Didn't raise an issue, though I can if it helps.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)