Added useful message for thrown exception #48878
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschu1ze
changed the title
rschu1ze
reviewed
Apr 18, 2023
| else | ||
| throw Exception(ErrorCodes::UNKNOWN_QUERY_PARAMETER, "Substitution {} is not set", backQuote(name)); | ||
| else { | ||
| try { |
There was a problem hiding this comment.
try { throw ... } catch looks a bit silly :-) What about including all information in the exception in the first place and not using try/catch? Alternatively, wrap the entire block in try such that a single catch may add all context.
There was a problem hiding this comment.
Thanks for the feedback! Sorry this is my first time working on an open source project (or anything outside of class projects) I'll take a look and clean it up.
rschu1ze
reviewed
Apr 18, 2023
| " because it isn't parsed completely: only {} of {} bytes was parsed: {}", | ||
| value, type_name, ast_param.name, read_buffer.count(), value.size(), value.substr(0, read_buffer.count())); | ||
| } | ||
| catch (const Exception & e) { |
There was a problem hiding this comment.
Perhaps (didn't check closer) function try blocks may help: https://stackoverflow.com/questions/5612486/when-is-a-function-try-block-useful
|
I will rewrite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #48772
Added try catch blocks to catch an exception thrown, add a message about the parameter that couldn't be parsed then throw new exception.