Should we remove calling initialize in sampler __repr__ method?

[amal-ghamdi]

Description:

initialize method change the state of the sampler. It is called in __repr__ which "apparently" is called behind the seen when debugging. Should we allow __repr__ to change the state of the sampler? This was a confusion point for me (@amal-ghamdi ) while debugging. For example consider this code

import cuqi
import numpy as np

uniform = cuqi.distribution.Uniform(np.array([0.0]), np.array([1.0]))
sampler = cuqi.experimental.mcmc.NUTS(uniform, initial_point=np.array([0.1]))
print(sampler._is_initialized)

Running this code will result in printing False, however, if run in debug mode, it will result in True.

DoD:

• Make a decision on the matter above, should we allow repr to change the sampler state.
• If the decision is to not allow repr to change the state, then update __repr__ and get the update reviewed and merged
• If the decision is to not allow repr to change the state, make sure the code above prints False in both debug and run modes

[amal-ghamdi]

@jakobsj , can you review the DoD if you got a chance. Thanks!