Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatTrak™ Music Kits and weapons wears. #116

Open
yesworId opened this issue Jun 4, 2024 · 3 comments
Open

StatTrak™ Music Kits and weapons wears. #116

yesworId opened this issue Jun 4, 2024 · 3 comments

Comments

@yesworId
Copy link

yesworId commented Jun 4, 2024

Would be great if music kits, which are contained in StatTrak™ Music Kit Box, would have StatTrak™ prefix in their names too.
Also, would be useful if every weapon skin would have it's wear ranges in crate content dictionary (min_float and max_float values) and not repeatedly written in every weapon skin with a different wear dictionaries (like weapon_id_0 - Factory New, weapon_id_1 - Minimal Wear....).

@yesworId
Copy link
Author

Another issue I've encounter, incorrect "Mil-Spec Grade" weapon wear in library's code. This wear should be "Mil-Spec"
These are correct list of all weapon wears, according to Valve's names:

WEAPON_RARITIES = [
    'Contraband',
    'Extraordinary',
    'Covert',
    'Classified',
    'Restricted',
    'Mil-Spec',
    'Mil-Spec Grade',  # IS INCORRECT NAME (BUT USED IN CSGO-API)
    'Industrial Grade',
    'Consumer Grade'
]

@ByMykel
Copy link
Owner

ByMykel commented Jun 17, 2024

Another issue I've encounter, incorrect "Mil-Spec Grade" weapon wear in library's code. This wear should be "Mil-Spec" These are correct list of all weapon wears, according to Valve's names:

WEAPON_RARITIES = [
    'Contraband',
    'Extraordinary',
    'Covert',
    'Classified',
    'Restricted',
    'Mil-Spec',
    'Mil-Spec Grade',  # IS INCORRECT NAME (BUT USED IN CSGO-API)
    'Industrial Grade',
    'Consumer Grade'
]

hmm if I am not mistaken I got the translation directly from csgo_english.json

image

EDIT: also thanks for the issue, lately I don't have a lot of free time to spend on this project, so it might be a long wait.

@yesworId
Copy link
Author

Sorry, I think I'm wrong. I double checked it in the steam community market filters and version with "Grade" is right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants