Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: a flag to see version of wslbridge and expose version to a ENV var in linux #29

Closed
sarim opened this issue Jan 12, 2021 · 7 comments
Closed

feature request: a flag to see version of wslbridge and expose version to a ENV var in linux #29

sarim opened this issue Jan 12, 2021 · 7 comments
Labels
enhancement ✨ New feature or request

Comments

@sarim
Copy link

sarim commented Jan 12, 2021

No description provided.

@Biswa96
Copy link
Owner

Biswa96 commented Jan 12, 2021

It is really necessary 🤔 There is no breaking changes between versions. I am reserving -v option for verbose mode or something else.

@sarim
Copy link
Author

sarim commented Jan 12, 2021 •
edited
Loading

In a perfect world It wouldn't be necessary but right now I'm switching between 3 terminals - Windows Terminal, wsltty/mintty, conemu (wslbridge2). I'm changing versions when encountering bugs. I thought it'll be useful to know which version of wslbridge I'm running.

After thinking some more, maybe you don't need to use a flag if you don't want to. Maybe add the version in -h output?

@Biswa96
Copy link
Owner

Biswa96 commented Jan 12, 2021

Maybe add the version in -h output?

OK, perfect choice.

Biswa96 added a commit that referenced this issue Jan 13, 2021
@Biswa96
Add version in help output (#29).
dad1b9c
@Biswa96 Biswa96 added the enhancement ✨ New feature or request label Jan 13, 2021
@Biswa96
Copy link
Owner

Biswa96 commented Jan 13, 2021

I have added the version number in help command output. Would you like to check it please?

@sarim
Copy link
Author

sarim commented Jan 13, 2021

Yes, it is working. (y) I'm just nitpicking at this point, but is manually defining version necessary? I think WSLBRIDGE2_VERSION can be defined from Makefile when compiling, and Makefile will get it by running git describe --long HEAD --tags

@Biswa96
Copy link
Owner

Biswa96 commented Jan 13, 2021 •
edited
Loading

Just a choice. That command will not work in shallow clone repository, which I do frequently. Also one does not have to install git to build this program from released tarball. 🤟

@Biswa96 Biswa96 closed this as completed Jan 13, 2021
@Biswa96
Copy link
Owner

Biswa96 commented Jan 22, 2021

I have re-tagged this change to v0.7 release.

goreliu pushed a commit to goreliu/wslbridge2 that referenced this issue Jan 31, 2021
@Biswa96 @goreliu
Add version in help output (Biswa96#29).
364c10e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sarim @Biswa96