-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature suggestion] Add the weather prediction to the calculation #193
Comments
good idea, hard to implement. will see how this goes. |
Weather query APIs generally aren't free, so I don't see this to be possible in the near future |
This is now theoretically possibly by using OpenWeather's OneCall API (https://openweathermap.org/api/one-call-api) I would put this feature in the ballpark of "possible, if more people contribute to it". |
Good idea would love to support it |
if you want to contribute, it would be nice to have a proof of concept C# application that reads and parses openweathermap API data |
I think a good way to implement this would be to create a WeatherHandler and introduce an additional offset variable. ConceptThe WeatherHandler is responsibe for querying the weather API and returning weather information for a provided geo position (Lat/Lon) It would be a static class that has at least two public methods handle
For example
Ideally that happens asynchronously so the application doesn't pause. Having that WeatherHandler available would go a long way in being able to implement this. Integration in ADMThat weatherhandle can be wrapped by a module and update periodically. ConfigThe rest would involve creating a config that stores offset values for certain weather types.
|
Typically, when it's rainy (maybe snowy as well; can't test in Israel), the sky will become darker earlier due to many clouds being together across a wide area
Currently, to combat this I need to manually specify a large offset (the other day it was as much as -66 minutes), but it isn't reliable, as in Israel the next day might be sunny, thus the sky will turn dark later
I believe that the calculation shouldn't be hard: If it's predicted to be rainy (e.g. showers), offset the time to the rain time if it's close to the afternoon (e.g. 3 PM)
The text was updated successfully, but these errors were encountered: